Open
Conversation
Member
|
Sorry for late reply. I try to merge it and it works fine. I rewrite server independently to use network-conduit, and allow MonadTrans. And network-conduit's interface (Source -> Sink -> m ()) is seems to be likely to use transport layer's interface. It is simple and flexible. I adopt your patch to this interface. What do you think about it? |
SX91
pushed a commit
to SX91/msgpack-haskell
that referenced
this pull request
Feb 27, 2017
`cabal sdist` doesn't include bench and test modules. Fixes msgpack#20 Fixes msgpack#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary Haskell support for RPC across ZeroMQ Rep-Req sockets.
This pull request aims to stimulate discussion to find the best approach for abstracting the transport layer from the Haskell msgpack RPC implementation. I do not intend to have this merged as-is into master.
My currently implementation isn't elegant; largely a blatant copy-paste with network conduits replaced with zeromq calls. Perhaps the optimal approach is to write a zeromq conduit such that the RPC server and client is indifferent to the underlying conduit source?